Forum Index phpBB2MODs.com
... Under New Management ...
 
 Home  • FAQ  • Search  • Register 
 Forum Index  • Downloads  • Log in  

Site login problem

 
Post new topic   Reply to topic    Forum Index -> Discussion
View previous topic :: View next topic  
Author Message
Dicky



Joined: 25 Apr 2006
Posts: 7

PostPosted: Wed Apr 26, 2006 8:33 am    Post subject: Site login problem Reply with quote

I get a blank page when logging in.

Well, stupid me, I forgot that I needed to activate my account. Once activated, I was then able to log in. The error page does come up when entering an incorrect password. It just doesn't come up for an inactive member.
Back to top
View user's profile
Site Admin
Site Admin


Joined: 24 Apr 2006
Posts: 34

PostPosted: Wed Apr 26, 2006 3:15 pm    Post subject: Reply with quote

Thanks, I will take a look.
Back to top
View user's profile Send e-mail Visit poster's website
Dave Rathbun
MOD Author


Joined: 26 Apr 2006
Posts: 25
Location: everywhere, nowhere, somewhere

PostPosted: Tue May 16, 2006 4:18 pm    Post subject: Reply with quote

I have verified that this occurs on a vanilla board. I'm wondering if it's a bug in 2.0.20. Further testing will be done, and a bug logged / a fix created if so.
_________________
<sigh>
Back to top
View user's profile Visit poster's website
espicom



Joined: 25 Apr 2006
Posts: 5

PostPosted: Tue May 16, 2006 10:35 pm    Post subject: Reply with quote

Blank page on inactive login is a known bug. Even has a CVS fix... phpbb2.0.20: all fixes in one place.
Back to top
View user's profile
Dave Rathbun
MOD Author


Joined: 26 Apr 2006
Posts: 25
Location: everywhere, nowhere, somewhere

PostPosted: Tue May 16, 2006 11:24 pm    Post subject: Reply with quote

Thanks. Cool

Fix applied.
_________________
<sigh>
Back to top
View user's profile Visit poster's website
Dicky



Joined: 25 Apr 2006
Posts: 7

PostPosted: Wed May 24, 2006 11:29 pm    Post subject: Reply with quote

espicom wrote:
Blank page on inactive login is a known bug. Even has a CVS fix... phpbb2.0.20: all fixes in one place.

The fix that is in that post is not what is in the cvs. I feel that the one in the cvs is a better fix. All the fix does is move a brace.
Code:
#
#-----[ OPEN ]------------------------------------------
#
login.php
#
#-----[ FIND ]------------------------------------------
#

                  $db->sql_query($sql);
               }
               
               $redirect = ( !empty($HTTP_POST_VARS['redirect']) ) ? str_replace('&amp;', '&', htmlspecialchars($HTTP_POST_VARS['redirect'])) : '';
               $redirect = str_replace('?', '&', $redirect);

               if (strstr(urldecode($redirect), "\n") || strstr(urldecode($redirect), "\r"))
               {
                  message_die(GENERAL_ERROR, 'Tried to redirect to potentially insecure url.');
               }

               $template->assign_vars(array(
                  'META' => "<meta http-equiv=\"refresh\" content=\"3;url=login.$phpEx?redirect=$redirect\">")
               );

               $message = $lang['Error_login'] . '<br /><br />' . sprintf($lang['Click_return_login'], "<a href=\"login.$phpEx?redirect=$redirect\">", '</a>') . '<br /><br />' .  sprintf($lang['Click_return_index'], '<a href="' . append_sid("index.$phpEx") . '">', '</a>');

               message_die(GENERAL_MESSAGE, $message);
            }
         }
      }
#
#-----[ REPLACE WITH ]------------------------------------------
#
                    $db->sql_query($sql);
                 }
             }
 
             $redirect = ( !empty($HTTP_POST_VARS['redirect']) ) ? str_replace('&amp;', '&', htmlspecialchars($HTTP_POST_VARS['redirect'])) : '';
             $redirect = str_replace('?', '&', $redirect);
 
             if (strstr(urldecode($redirect), "\n") || strstr(urldecode($redirect), "\r"))
             {
                message_die(GENERAL_ERROR, 'Tried to redirect to potentially insecure url.');
             }
 
             $template->assign_vars(array(
                'META' => "<meta http-equiv=\"refresh\" content=\"3;url=login.$phpEx?redirect=$redirect\">")
             );
 
             $message = $lang['Error_login'] . '<br /><br />' . sprintf($lang['Click_return_login'], "<a href=\"login.$phpEx?redirect=$redirect\">", '</a>') . '<br /><br />' .  sprintf($lang['Click_return_index'], '<a href="' . append_sid("index.$phpEx") . '">', '</a>');
 
             message_die(GENERAL_MESSAGE, $message);
           }
        }
#
#-----[ SAVE/CLOSE ALL FILES ]------------------------------------------
#
# EoM
Back to top
View user's profile
Display posts from previous:   
Post new topic   Reply to topic    Forum Index -> Discussion All times are GMT - 5 Hours
Page 1 of 1

 
Jump to:  
Powered by phpBB © 2001, 2005 phpBB Group Brought to you by the phpBBDoctor.com phpBBDoctor